-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update {regr,classif}.ranger
learner for 0.17.0
#321
Conversation
Yes we should keep this. 2 Cores and future is still a bad choice. Thanks for updating. |
The dev-check is failing because of the Also from what I can see the only other regression task included in |
Yes I will change that.
Just use mtcars for now. |
So wait, should I change The only other thing left is Apart from that I think this is finished so far. |
Merge main and it should be changed
Yes, that makes tuning more complicated. But make it a |
Gotcha, done. Currently the autotest fails, but that's due to |
Diff from 0.16.0 to 0.17.0: https://github.com/imbs-hl/ranger/compare/4795a99d43667b47991883fd6ff44e15b2891237..master
Changes to account for:
regr.ranger
poisson.tau
parameter (depends on poisson splitrule being selected)beta
splitrule which was added earlier but wasn't available inregr.ranger
"missings"
property for{regr,classif}.ranger
na.action
parameter for{regr,classif}.ranger
, defaulting to"na.learn"
classif.ranger
, letmin.node.size
andmin.bucket
also be vectors for class-wise values.Would that mean these params need to be
p_uty
s?Also, ranger changed the default for
num.threads
, but since this is overriden anyway I didn't touch that part.I guess the ranger dependency in
DESCRIPTION
should be bumped to 0.17.0 as well, right?