Replace MultiValue::extend_from_values with from_lua_iter

mlua-rs · Aug 6, 2024 · 10999ba · 10999ba
1 parent f0a995a
commit 10999ba
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/multi.rs b/src/multi.rs
@@ -177,9 +177,7 @@ impl<T> DerefMut for Variadic<T> {
 impl<T: IntoLua> IntoLuaMulti for Variadic<T> {
     #[inline]
     fn into_lua_multi(self, lua: &Lua) -> Result<MultiValue> {
-        let mut values = MultiValue::with_capacity(self.0.len());
-        values.extend_from_values(self.0.into_iter().map(|val| val.into_lua(lua)))?;
-        Ok(values)
+        MultiValue::from_lua_iter(lua, self)
     }
 }
 

diff --git a/src/value.rs b/src/value.rs
@@ -814,11 +814,13 @@ impl MultiValue {
     }
 
     #[inline]
-    pub(crate) fn extend_from_values(&mut self, iter: impl IntoIterator<Item = Result<Value>>) -> Result<()> {
+    pub(crate) fn from_lua_iter<T: IntoLua>(lua: &Lua, iter: impl IntoIterator<Item = T>) -> Result<Self> {
+        let iter = iter.into_iter();
+        let mut multi_value = MultiValue::with_capacity(iter.size_hint().0);
         for value in iter {
-            self.push_back(value?);
+            multi_value.push_back(value.into_lua(lua)?);
         }
-        Ok(())
+        Ok(multi_value)
     }
 }