Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

printer: constraints formatting #209

Merged
merged 2 commits into from
Oct 29, 2021
Merged

Conversation

mmcloughlin
Copy link
Owner

Uses buildtag.Format to format constraints in the assembly and stub file
printers. This will ensure // + build and //go:build syntax are used
consistent with the current Go version.

Updates #183

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2021

Codecov Report

Merging #209 (2f15d6a) into master (55d98cc) will decrease coverage by 0.00%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
- Coverage   75.64%   75.64%   -0.01%     
==========================================
  Files          57       57              
  Lines       35114    35120       +6     
==========================================
+ Hits        26563    26567       +4     
- Misses       8399     8400       +1     
- Partials      152      153       +1     
Flag Coverage Δ
integration 8.78% <20.00%> (+0.04%) ⬆️
unittests 73.30% <40.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
printer/goasm.go 94.01% <40.00%> (-2.48%) ⬇️
printer/stubs.go 78.57% <40.00%> (+6.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55d98cc...2f15d6a. Read the comment docs.

@mmcloughlin mmcloughlin marked this pull request as ready for review October 29, 2021 08:06
@mmcloughlin mmcloughlin merged commit 79bee1a into master Oct 29, 2021
@mmcloughlin mmcloughlin deleted the printer-constraints-format branch October 29, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants