Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add body-custom include to facilitate loading custom elements at the body start #404

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eddgrant
Copy link

This is a bug fix.

Summary

Hi, I am in the process of setting up Google Tag Manager and am using the t-richards/jekyll-google-tag-manager plugin. GTM seems to require code to be inserted as the first thing in the <body> element in order to function. To support this I have introduced a body-custom.html include. I thought this have other, more general, use cases so wanted to offer it back in case you are keen to include it. Having it included upstream also benefits me of course as I no longer have to maintain a custom default.html 😁 .

Let me know what you think, but regardless of your decision thank you for all your work on the theme, it's really excellent 🙏

Edd

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity.

This pull request will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions.

@olifre
Copy link

olifre commented May 14, 2021

As a user, I also consider this a very useful feature and would love seeing this merged. The stale-bot sadly encourages bumping PRs to keep them open, and there seem to be no maintainers of the project around 😢 .

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity.

This pull request will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions.

@olifre
Copy link

olifre commented Jul 15, 2021

The dreaded stale-bot passed by again — it sadly encourages bumping PRs to keep them open, and there seem to be no maintainers of the project around 😢.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity.

This pull request will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions.

@olifre
Copy link

olifre commented Sep 15, 2021

The dreaded stale-bot passed by again — it sadly encourages bumping PRs to keep them open, and there seem to be no maintainers of the project around 😢.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants