Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC layer symfony/event-dispatcher #201

Merged
merged 2 commits into from
Nov 16, 2021
Merged

BC layer symfony/event-dispatcher #201

merged 2 commits into from
Nov 16, 2021

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Oct 25, 2021

this could generally work as a patch-release IMHO.

A potential BC break can occur if someone relies on type checking the deprecated event class, whereas the new release will extend the contract-event class ...

Any next-version works for us 👍

@ro0NL
Copy link
Contributor Author

ro0NL commented Oct 25, 2021

conflicts with #188, cc @mmoreram also :}

@daum
Copy link
Collaborator

daum commented Oct 27, 2021

@ro0NL thanks at the high level this looks like it should be fine. It looks like our travis CI test integration isn't running, i'll try to get some time to look at this later this week.

@ro0NL
Copy link
Contributor Author

ro0NL commented Oct 28, 2021

to make life easier ... perhaps conflict with event-dispatcher <4.4, drop ^3.0 support, release a new major. Be happy :)

That's however maintenance i cannot do for you :)

@ro0NL
Copy link
Contributor Author

ro0NL commented Nov 16, 2021

@daum any verdict?

@daum
Copy link
Collaborator

daum commented Nov 16, 2021

@ro0NL sorry I didn't get a chance to look at this been hectic at work and heading out on a holiday shortly. @ro0NL depending on @mmoreram thoughts, would you also be interested in helping out with maintenance of the bundle? I don't use it that heavily anymore and have a few other things that are taking up my time so hard to get it the proper time it deserves.

That said will do my best to pull this down and run the tests suite to see if we can get this merged before i head out. I agree this should be a patch release most likely.

@ro0NL
Copy link
Contributor Author

ro0NL commented Nov 16, 2021

Im afraid we'll be eventually migrating to symfony/messenger (https://github.com/Slickdeals/gearman-messenger) 😂

So maybe it's a dead end, but the deprecations in prod drove me here :D

@ro0NL ro0NL closed this Nov 16, 2021
@ro0NL ro0NL reopened this Nov 16, 2021
@daum
Copy link
Collaborator

daum commented Nov 16, 2021

@ro0NL awesome thanks for sending that over didn't know of it before, very good to know about.

Copy link
Collaborator

@daum daum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all tests are passing and working.

@daum daum merged commit 8acdec8 into mmoreram:master Nov 16, 2021
@ro0NL ro0NL deleted the deprecations branch November 17, 2021 07:36
@ro0NL ro0NL mentioned this pull request Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants