Fix bug: task was ending when signal was received not after was evaluated #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draage2572
reviewed
Oct 19, 2023
Command/GearmanJobExecuteCommand.php
Outdated
| @@ -79,6 +79,16 @@ protected function configure() | |||
|
|
|||
| protected function execute(InputInterface $input, OutputInterface $output) | |||
| { | |||
| if (extension_loaded('pcntl') && function_exists('pcntl_async_signals')) { | |||
There was a problem hiding this comment.
extension loaded should be enough, no need to check for the function
Command/GearmanJobExecuteCommand.php
Outdated
| if (extension_loaded('pcntl') && function_exists('pcntl_async_signals')) { | ||
| pcntl_async_signals(true); | ||
|
|
||
| pcntl_signal(SIGTERM, [$this->gearmanExecute, 'handleSystemSignal']); |
There was a problem hiding this comment.
should register signal handling on the executor itself
mihaileu
approved these changes
Oct 19, 2023
switch to ubuntu-22.04 as runner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When was receiving a signal "SIGTERM/SIGHUP" the process immediately exist instead of waiting until gearman current task end.
This fix make it to work as was intended: on signal put a flag on true, before get next task if flag is true stop and exit.