Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine Performance History Graph #14

Open
8 of 11 tasks
qinsoon opened this issue Aug 19, 2020 · 1 comment
Open
8 of 11 tasks

Refine Performance History Graph #14

qinsoon opened this issue Aug 19, 2020 · 1 comment

Comments

@qinsoon
Copy link
Member

qinsoon commented Aug 19, 2020

Based on the graph in mmtk/mmtk-core#125 and https://github.com/mmtk/ci-perf-kit/releases/tag/0.3.3

  • Use revision for X axis instead of day. Every run should show in the graph.
  • Make the graphs smaller (ideally we want to show all the benchmarks in one page)
  • Put benchmark names above the big number on the right
  • Use log scale for X axis (show more details in recent days/commits)
  • Calculate 10p moving average of 'standard deviation for each data point'. The gray area should be 10p moving average +/- 10p moving average of std dev.
  • Show absolute number for the current data (below the big number)
  • The annotation for the best number should be below the line, and the annotation for the worst number should be above the line.
  • Add link to the data point.

Added:

  • Use triangle (as the marker for max/min points)
  • Use triangle as background for the big number
  • Show xticks
@qinsoon
Copy link
Member Author

qinsoon commented Aug 24, 2020

#15 solved most of the issues here. There are a few left:

  • log scale X: I am not sure how to do a log-scale x axis that are dense on the left
  • add link: plotly (the plot library I am using does not provide support for links. There are hacks to achieve this though. )
  • show x ticks: I couldn't figure out how to put x labels on the last subgraphs (by default, the labels are put to the x axis of the first subgraph)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant