Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Plotting of Performance History Data #125

Merged
merged 19 commits into from
Aug 31, 2020
Merged

Better Plotting of Performance History Data #125

merged 19 commits into from
Aug 31, 2020

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented Aug 12, 2020

Changes:

  • Update ci-perf-kit to 0.3.5
    • plot 10-point moving average with performance history data
    • plot +-1 standard deviation from 10p moving average
    • highlight the max/min number in the graph
    • normalize all the data to the min value
    • log timeline
  • Plots for each branch are now stored in separate directories
    • Plots for a branch can co-exist with the plots for master

Examples for the new graph:

@qinsoon qinsoon marked this pull request as ready for review August 17, 2020 03:38
@qinsoon qinsoon requested a review from caizixian August 17, 2020 03:39
@qinsoon qinsoon added the PR-ready-for-review Pull request ready for review label Aug 17, 2020
@github-actions
Copy link

JikesRVM

NoGC (wrench-2020-08-17-Mon-174657)

Benchmark Trunk(ms) Branch(ms) Diff
mean mean without outliers median mean mean without outliers median mean mean without outliers
antlr 783.95 ±2.70 783.95 ±2.70 786.5 781.15 ±7.17 778.23 ±4.18 ⚠️ 1 removed 778.0 -0.36% -0.73%
fop 623.90 ±1.40 623.54 ±1.22 ⚠️ 1 removed 623.0 621.92 ±1.41 621.92 ±1.41 621.5 -0.32% -0.26%
luindex 2312.72 ±5.33 2311.41 ±4.74 ⚠️ 1 removed 2314.5 2306.55 ±6.50 2304.82 ±5.63 ⚠️ 1 removed 2309.0 -0.27% -0.29%

SemiSpace (wrench-2020-08-17-Mon-175858)

Benchmark Trunk(ms) Branch(ms) Diff
mean mean without outliers median mean mean without outliers median mean mean without outliers
antlr 647.88 ±6.16 645.79 ±4.61 ⚠️ 1 removed 644.0 647.40 ±4.77 647.40 ±4.77 646.0 -0.07% +0.25%
bloat 2472.78 ±25.54 2472.78 ±25.54 2470.0 2471.78 ±26.47 2471.78 ±26.47 2497.5 -0.04% -0.04%
fop 586.55 ±1.31 586.55 ±1.31 587.0 586.75 ±2.00 586.03 ±1.40 ⚠️ 1 removed 586.5 +0.03% -0.09%
hsqldb 1127.75 ±15.82 1127.75 ±15.82 1154.5 1138.83 ±19.76 1132.85 ±16.05 ⚠️ 1 removed 1156.5 +0.98% +0.45%
jython 1841.97 ±7.55 1841.97 ±7.55 1844.5 1832.95 ±7.95 1830.85 ±6.89 ⚠️ 1 removed 1833.5 -0.49% -0.60%
luindex 2381.69 ±10.02 ⚠️ 1/40 failed 2381.69 ±10.02 2385.0 2375.18 ±8.38 ⚠️ 1/40 failed 2375.18 ±8.38 2378.0 -0.27% -0.27%
lusearch 686.90 ±4.21 685.72 ±3.55 ⚠️ 1 removed 681.5 685.85 ±3.82 ⚠️ 1/40 failed 683.86 ±2.74 ⚠️ 2 removed 685.0 -0.15% -0.27%
pmd 1510.53 ±11.01 1510.53 ±11.01 1506.5 1505.28 ±7.02 1505.28 ±7.02 1502.0 -0.35% -0.35%
xalan 501.15 ±2.88 ⚠️ 1/40 failed 501.15 ±2.88 503.0 505.13 ±2.63 ⚠️ 1/40 failed 505.13 ±2.63 505.0 +0.79% +0.79%

@github-actions
Copy link

OpenJDK

SemiSpace (wrench-2020-08-17-Mon-194451)

Benchmark Trunk(ms) Branch(ms) Diff
mean mean without outliers median mean mean without outliers median mean mean without outliers
antlr 408.59 ±6.66 ⚠️ 6/40 failed 408.59 ±6.66 409.5 411.03 ±7.23 ⚠️ 6/40 failed 411.03 ±7.23 407.0 +0.60% +0.60%
eclipse 7827.77 ±32.05 ⚠️ 1/40 failed 7827.77 ±32.05 7824.0 7814.54 ±37.29 ⚠️ 1/40 failed 7814.54 ±37.29 7787.0 -0.17% -0.17%
fop 465.38 ±2.54 465.38 ±2.54 461.5 466.20 ±3.82 464.95 ±2.94 ⚠️ 1 removed 462.0 +0.18% -0.09%
hsqldb 1113.69 ±13.87 ⚠️ 1/40 failed 1113.69 ±13.87 1117.0 1102.08 ±17.59 1102.08 ±17.59 1113.5 -1.04% -1.04% 🟩
pmd 1401.92 ±11.53 1401.92 ±11.53 1400.0 1411.22 ±11.72 1411.22 ±11.72 1405.5 +0.66% +0.66%

@qinsoon qinsoon removed the PR-ready-for-review Pull request ready for review label Aug 19, 2020
@mmtk mmtk deleted a comment from github-actions bot Aug 19, 2020
@mmtk mmtk deleted a comment from github-actions bot Aug 19, 2020
@mmtk mmtk deleted a comment from github-actions bot Aug 19, 2020
@mmtk mmtk deleted a comment from github-actions bot Aug 19, 2020
@qinsoon qinsoon added PR-under-review Pull request currently in review process and removed PR-benchmarking labels Aug 19, 2020
@qinsoon
Copy link
Member Author

qinsoon commented Aug 19, 2020

After a discussion with Steve, Steve suggested some changes (mmtk/ci-perf-kit#14). I will address those changes before we merge this PR.

@qinsoon
Copy link
Member Author

qinsoon commented Aug 26, 2020

Suggested changes are made, and I bumped ci-perf-kit to 0.3.5.

Can at least one of you review this PR and approve it? @steveblackburn @caizixian @wenyuzhao

@qinsoon qinsoon added PR-ready-for-review Pull request ready for review and removed PR-under-review Pull request currently in review process labels Aug 26, 2020
Copy link
Member

@caizixian caizixian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking at https://mmtk.github.io/ci-perf-result/refs_pull_125_merge/jikesrvm_semispace_history.html , and it doesn't seem to render properly on Firefox 80.0/Chrome 83.0.4103.116 on macOS
Screen Shot 2020-08-27 at 18 24 45

@wenyuzhao
Copy link
Member

I'm looking at https://mmtk.github.io/ci-perf-result/refs_pull_125_merge/jikesrvm_semispace_history.html , and it doesn't seem to render properly on Firefox 80.0/Chrome 83.0.4103.116 on macOS
Screen Shot 2020-08-27 at 18 24 45

I think it's because the variance of some benchmark is too large, so the extra height for the subplot overlaps with others.

@qinsoon
Copy link
Member Author

qinsoon commented Aug 28, 2020

I'm looking at https://mmtk.github.io/ci-perf-result/refs_pull_125_merge/jikesrvm_semispace_history.html , and it doesn't seem to render properly on Firefox 80.0/Chrome 83.0.4103.116 on macOS
Screen Shot 2020-08-27 at 18 24 45

Yeah, the graph was rendered from the test branch of the result repository (https://github.com/mmtk/ci-perf-result/tree/test). It includes data from the Github hosted runner and our self hosted runner so the results vary a lot. The label of the subgraph below overlaps the the subgraph above. This should not happen if we have a 'normal' graph.

@qinsoon qinsoon merged commit 46f3231 into master Aug 31, 2020
@qinsoon qinsoon deleted the new-plot branch August 31, 2020 00:14
qinsoon added a commit that referenced this pull request Sep 1, 2020
* Get branch name from GITHUB_REF, deploy pages by branch name
* Use ci-perf-kit 0.3.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-ready-for-review Pull request ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants