Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH, MAINT] MNE Scan: decouple gui from core #886

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

gabrielbmotta
Copy link
Collaborator

  • Add new ScanCore class, based on AnalyeCore.
  • Separate plugin loading and measurement controls from main window -> now in ScanCore.
    • PluginManager and PluginSceneManager now initialized in ScanCore, shared with MainWindow
    • startMeasurement() and stopMeasurement() in MainWindow deal with GUI elements, but call on ScanCore to start/stop plugins.
  • main.cpp now creates an instance of ScanCore as opposed to MainWindow.

@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #886 (351ed3a) into main (bd31738) will decrease coverage by 0.90%.
The diff coverage is n/a.

❗ Current head 351ed3a differs from pull request most recent head 9c0b186. Consider uploading reports for the commit 9c0b186 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #886      +/-   ##
==========================================
- Coverage   30.20%   29.29%   -0.91%     
==========================================
  Files         452      196     -256     
  Lines       39208    11553   -27655     
==========================================
- Hits        11841     3385    -8456     
+ Misses      27367     8168   -19199     
Impacted Files Coverage Δ
libraries/fiff/fiff_types.h 0.00% <0.00%> (-100.00%) ⬇️
libraries/fwd/fwd_bem_model.h 0.00% <0.00%> (-100.00%) ⬇️
libraries/fiff/fiff_info_base.h 0.00% <0.00%> (-100.00%) ⬇️
libraries/mne/mne_sourcespace.h 0.00% <0.00%> (-100.00%) ⬇️
libraries/connectivity/network/network.h 0.00% <0.00%> (-100.00%) ⬇️
libraries/connectivity/connectivitysettings.h 0.00% <0.00%> (-100.00%) ⬇️
libraries/rtprocessing/helpers/filterkernel.h 0.00% <0.00%> (-100.00%) ⬇️
libraries/fwd/fwd_thread_arg.cpp 1.61% <0.00%> (-88.71%) ⬇️
libraries/fwd/fwd_bem_solution.cpp 21.42% <0.00%> (-78.58%) ⬇️
libraries/mne/mne_cluster_info.h 0.00% <0.00%> (-76.48%) ⬇️
... and 288 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants