-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH, MAINT] MNE Scan: decouple gui from core #886
Open
gabrielbmotta
wants to merge
8
commits into
mne-tools:main
Choose a base branch
from
gabrielbmotta:scancore
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gabrielbmotta
commented
Jan 28, 2022
- Add new ScanCore class, based on AnalyeCore.
- Separate plugin loading and measurement controls from main window -> now in ScanCore.
- PluginManager and PluginSceneManager now initialized in ScanCore, shared with MainWindow
- startMeasurement() and stopMeasurement() in MainWindow deal with GUI elements, but call on ScanCore to start/stop plugins.
- main.cpp now creates an instance of ScanCore as opposed to MainWindow.
Codecov Report
@@ Coverage Diff @@
## main #886 +/- ##
==========================================
- Coverage 30.20% 29.29% -0.91%
==========================================
Files 452 196 -256
Lines 39208 11553 -27655
==========================================
- Hits 11841 3385 -8456
+ Misses 27367 8168 -19199
|
juangpc
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.