Improve error message if qt binding could not be found #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
reviewed
Oct 2, 2023
larsoner
reviewed
Oct 2, 2023
mne_qt_browser/_pg_figure.py
Outdated
Comment on lines
26
to
35
| from qtpy.QtCore import ( | ||
| QEvent, | ||
| QThread, | ||
| Qt, | ||
| Signal, | ||
| QRectF, | ||
| QLineF, | ||
| QPointF, | ||
| QPoint, | ||
| QSettings, |
There was a problem hiding this comment.
I would also just nest one of these imports, then the rest can be as they were before. It'll make the diff smaller as well
There was a problem hiding this comment.
Thanks for the comments @larsoner
larsoner
reviewed
Oct 2, 2023
Co-authored-by: Eric Larson <[email protected]>
Co-authored-by: Eric Larson <[email protected]>
for more information, see https://pre-commit.ci
larsoner
reviewed
Oct 2, 2023
larsoner
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Marking for merge when green, thanks in advance @timonmerk !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #199, this PR checks before the first qtpy import if the
QtBindingsNotFoundErrorexception is thrown. The error message now hints that pyqt5 needs to be installed.