Enh sensitivity UI change

[nmarkowitz]

Reference issue

#230 , #212 , #208 , mne-tools/mne-python#10888 , #273

What does this implement/fix?

Extends #273 by enabling sensitivity spinboxes to be updated

[nmarkowitz]

@larsoner can you remind me, how can I calculate logical dpi and where should QApplication.primaryScreen().devicePixelRatio() be used for this calculation?

[larsoner]

On a HiDPI macOS system for example that has a pixel ratio of 2, making a screen with logical / user size 800x600 you can get the physical pixels by multiplying by the ratio:

>>> from PyQt6 import QtWidgets, QtCore
>>> app = QtWidgets.QApplication([])
>>> window = QtWidgets.QMainWindow(size=QtCore.QSize(800, 600))
>>> window.size().height()
600
>>> window.size().width()
800
>>> window.screen().devicePixelRatio() * window.size().height()
1200.0
>>> window.screen().devicePixelRatio() * window.size().width()
1600.0

[larsoner]

Okay some quick feedback:

• Changing to / inch did not update the Monitor boxes for me
• Resizing the window did not update the Sensitivity values
• I think it would be good to insert a third row "Monitor DPI" to the "Monitor Size" section. When any of the three height/width/dpi changes, the other two (and sensitivity values) should update as well.

Let me know when these work for you and I'll take a look! Feel free to add some basic tests as well if you want, we'll want them before merge

[larsoner]

... or rather, the wrong stuff updates when I click the / inch in the monitor section. It updates the upper set of boxes, when really it should update the lower set. In other words if I have this to start:

If I click the Monitor Size dropdown / mm and change it to / inch, the sensitivity values shouldn't change, the monitor values should change to 222.52mm/25.4=8.76in, i.e., it changes the units but not the screen size, it doesn't use the old float with the new units to set a new size. So what it does now, which is this, is incorrect:

It should be more like this:

But even when I change it manually to a height of 8.76 (as in the image above) something is wrong, because the grad sensitivity is now 73.6 fT/cm / mm instead of 83.1 fT/cm / mm despite inputting the same physical size for my monitor (granted, in different units, but this should be accounted for properly) and not changing the window size.

And regarding the "no update on resize", I noticed that when I resize I do get this in the terminal:

Traceback (most recent call last):
  File "/Users/larsoner/python/mne-qt-browser/mne_qt_browser/_pg_figure.py", line 5544, in resizeEvent
    self.mne.fig_settings._update_sensitivity_spinbox_values()
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'SettingsDialog' object has no attribute '_update_sensitivity_spinbox_values'

[larsoner]

Just pushed a tiny commit to fix the row number of the Reset button, other than that it worked well!

Still needs tests though

[mscheltienne]

FYI: https://mne.discourse.group/t/how-access-small-vertical-voltage-line-when-plotting-raw-eeg-changing-voltage-amplitude-when-plotting/9243

[nmarkowitz]

@mscheltienne @larsoner I think this is ready. Can you check out and confirm for yourselves?

[wmvanvliet]

Functionally, this works very nicely on my Windows machine.

[larsoner]

@nmarkowitz I assume you just forgot to take the PR out of draft mode? Works well for me as well so I'll go ahead and merge, thanks!