Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent multiple loading of DatasetAttributes in N5OMEZarrImageLoader #100

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

tischi
Copy link
Collaborator

@tischi tischi commented Jun 17, 2022

Addresses #99

@tischi tischi requested a review from KateMoreva June 17, 2022 09:43
@tischi
Copy link
Collaborator Author

tischi commented Jun 17, 2022

@KateMoreva

Could you please have a look whether my changes make sense?

If you have some time, it would be great checking whether all the calls n5.getAttribute(...) are strictly needed and/or whether we could cache some return values.

In general, all interaction with the S3 storage is quite costly and thus should be minimized.

Thanks!

@KateMoreva
Copy link
Collaborator

@KateMoreva

Не могли бы вы посмотреть, имеют ли смысл мои изменения?

Если у вас есть немного времени, было бы здорово проверить, все ли вызовы n5.getAttribute(...)строго необходимы и/или можно ли кэшировать некоторые возвращаемые значения.

В целом все взаимодействие с хранилищем S3 довольно затратно и поэтому должно быть сведено к минимуму.

Спасибо!

Sure, I'll continue with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants