Fix "ImportError" for jsonschema #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrangeTux
force-pushed
the
471-fix-import-error-for-more-recent-json-schemas
branch
from
a57e415
to
c67ca12
Compare
This library relied on a private API of jsonschema to map a validation error to the right `OCPPError`. As of jsonschema==4.19.0, the private API has changed.[^1]. Using the latest release of jsonschema with this library caused an `ImportError`. This commit removes the dependency on the private API. [^1]: python-jsonschema/jsonschema@9313230
OrangeTux
force-pushed
the
471-fix-import-error-for-more-recent-json-schemas
branch
from
c67ca12
to
da4eb20
Compare
OrangeTux
changed the title
proelke
approved these changes
Sep 26, 2023
jainmohit2001
deleted the
471-fix-import-error-for-more-recent-json-schemas
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library relied on a private API of jsonschema to map a validation error to the right
OCPPError. As of jsonschema==4.19.0, the private API has changed.1. Using the latest release of jsonschema with this library caused anImportError.This commit removes the dependency on the private API.
Fixes #471
Footnotes
https://github.com/python-jsonschema/jsonschema/commit/931323043b4409a0416f373403bfb52408fc282f ↩