Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documents for 2.0.1 to lastest #486

Merged
merged 4 commits into from
Oct 16, 2023

Conversation

Jared-Newell-Mobility
Copy link
Contributor

Also remove 2.0 docs

Copy link
Collaborator

@OrangeTux OrangeTux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's cumbersome task to add this enums, so thanks for the PR!

I didn't finish the review yet, since I found a few enums which are missing variants. That makes me wonder, based on which documents are the enums based? Are they based on the latest errata?

@Jared-Newell-Mobility
Copy link
Contributor Author

@OrangeTux - for comment #486 (review) - I'll reply under #487 which I think this is what you are referring to

@OrangeTux
Copy link
Collaborator

Yeah, your right. I posted my comment in the wrong PR. Let's keep the discussion at #487

@Jared-Newell-Mobility Jared-Newell-Mobility merged commit b181582 into master Oct 16, 2023
6 checks passed
@Jared-Newell-Mobility Jared-Newell-Mobility deleted the Update-documents-for-2.0.1-to-lastest branch October 16, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants