Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add optional param for passing a custom logger to ChargePoint #641

Closed
wants to merge 5 commits into from

Conversation

hhuseyinpay
Copy link

This pull request introduces a logger parameter to the ChargePoint class's __init__ function. This allows users to specify a custom logger, enhancing flexibility and control over logging.

@jainmohit2001
Copy link
Collaborator

HI @hhuseyinpay, can you update the PR with the required formatting. Single quotes (') must to be converted to double quotes (")

@hhuseyinpay
Copy link
Author

done

@jainmohit2001
Copy link
Collaborator

jainmohit2001 commented Sep 24, 2024

ocpp/charge_point.py:209:89: E501 line too long (111 > 88 characters)

Can you please update the respective line?

@jainmohit2001
Copy link
Collaborator

There are still some formatting issues. It seems like the New line character is different from what is expected by the code quality check, cause all the visible characters are the same.

@hhuseyinpay
Copy link
Author

I don't know how to do that. I use Pycharm with default settings

@jainmohit2001
Copy link
Collaborator

@jainmohit2001
Copy link
Collaborator

Some more formatting issues.

@hhuseyinpay
Copy link
Author

I've spent enough time on this. I'm no longer interested in this. You can easily make these changes yourself. If formatting is that important, consider writing a simple pre-commit script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants