Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Changed total_cost type from Optional[int] to Optional[float] #663

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

jainmohit2001
Copy link
Collaborator

Fixes #657

@jainmohit2001
Copy link
Collaborator Author

There seems to be some issue with the tests (3.7) check.

@OrangeTux
Copy link
Collaborator

Python 3.7 is not supported anymore. I've no idea what that check is still shown in Github. You can ignore GH .

@jainmohit2001 jainmohit2001 added bug Something isn't working ocpp2.1 Issues related to OCPP 2.1 support labels Sep 30, 2024
@jainmohit2001
Copy link
Collaborator Author

Python 3.7 is not supported anymore. I've no idea what that check is still shown in Github. You can ignore GH .

Can you check settings for the repo? I think under the branch management or branch rules, we should be able to find this check. We need to manually remove it from there.

@proelke
Copy link
Collaborator

proelke commented Oct 10, 2024

It is now removed from the branch protection rules

@jainmohit2001 jainmohit2001 force-pushed the transaction-event-payload-dataclass-fix branch from 15d25f3 to a082cf3 Compare October 15, 2024 09:13
@jainmohit2001 jainmohit2001 changed the title Changed total_cost type from Optional[int] to Optional[float] bugfix: Changed total_cost type from Optional[int] to Optional[float] Oct 15, 2024
@jainmohit2001 jainmohit2001 merged commit bef39f6 into master Oct 15, 2024
6 checks passed
@jainmohit2001 jainmohit2001 deleted the transaction-event-payload-dataclass-fix branch October 15, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ocpp2.1 Issues related to OCPP 2.1 support
Development

Successfully merging this pull request may close these issues.

TransactionEventPayload total_cost should be a floating point number
3 participants