Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve third-party reporters example #104

Merged
merged 7 commits into from
Jan 3, 2025
Merged

fix: Improve third-party reporters example #104

merged 7 commits into from
Jan 3, 2025

Conversation

mark-wiemer
Copy link
Contributor

PR Checklist

Overview

  • Link to more comprehensive API and tutorial docs (not the GitHub wiki, as that's outdated)
  • Add sample failing test

@mark-wiemer mark-wiemer changed the title Mark wiemer/mocha 3104 third party reporter Fix: Improve third-party reporters example Jan 3, 2025
@mark-wiemer mark-wiemer changed the title Fix: Improve third-party reporters example fix: Improve third-party reporters example Jan 3, 2025
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

Bonus points for improving the accessibility of the inline text links. 😄

@JoshuaKGoldberg JoshuaKGoldberg merged commit 48f723f into mochajs:main Jan 3, 2025
1 of 4 checks passed
@mark-wiemer mark-wiemer deleted the mark-wiemer/mocha-3104-third-party-reporter branch January 4, 2025 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mark-wiemer @JoshuaKGoldberg