Skip to content

Commit

Permalink
chore: pin node-lts tests to 22.11.0 (#5279)
Browse files Browse the repository at this point in the history
* chore: pin node-lts tests to 22.11.0

* Also update other 22s
  • Loading branch information
JoshuaKGoldberg authored Jan 2, 2025
1 parent a87fb11 commit 664e1f4
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/mocha.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ jobs:
smoke:
uses: ./.github/workflows/npm-script.yml
with:
node-versions: '14,22,lts/*'
# The 22.11.0 is instead of lts per https://github.com/mochajs/mocha/issues/5278
node-versions: '18,20,22.11.0'
npm-script: test-smoke

test-node-lts:
Expand Down Expand Up @@ -64,7 +65,8 @@ jobs:
coverage: false
with:
os: 'ubuntu-latest,windows-latest'
node-versions: '14,16,18,20,22'
# The 22.11.0 is instead of 22 per https://github.com/mochajs/mocha/issues/5278
node-versions: '14,16,18,20,22.11.0'
npm-script: test-node:${{ matrix.test-part }}
coverage: ${{ matrix.coverage }}

Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/npm-script.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ jobs:
strategy:
fail-fast: false
matrix:
node_version: ${{ fromJson(needs.resolve-inputs.outputs.nodeVersions || '["lts/*"]') }}
# The 22.11.0 is instead of "lts/*" per https://github.com/mochajs/mocha/issues/5278
node_version: ${{ fromJson(needs.resolve-inputs.outputs.nodeVersions || '["22.11.0"]') }}
os: ${{ fromJson(needs.resolve-inputs.outputs.os || '["ubuntu-latest"]') }}
browser: ${{ fromJson(needs.resolve-inputs.outputs.browsers || '[""]') }}
steps:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/release-please.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ jobs:
show-progress: false
- uses: actions/setup-node@v4
with:
node-version: lts/*
# The 22.11.0 is instead of lts per https://github.com/mochajs/mocha/issues/5278
node-version: '22.11.0'
registry-url: 'https://registry.npmjs.org'

- name: Install dependencies
Expand Down

0 comments on commit 664e1f4

Please sign in to comment.