Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some rewiremock usages #4510

Closed
wants to merge 1 commit into from
Closed

fix some rewiremock usages #4510

wants to merge 1 commit into from

Conversation

boneskull
Copy link
Contributor

using the () => require(...) syntax is better for refactoring/intellisense/etc

@boneskull
fix some rewiremock usages
ba5fcf7 
using the `() => require(...)` syntax is better for refactoring/intellisense/etc
@boneskull boneskull added type: chore generally involving deps, tooling, configuration, etc. qa semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Nov 13, 2020
@boneskull boneskull self-assigned this Nov 13, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.116% when pulling ba5fcf7 on boneskull/rewiremock-fix into c6856ba on master.

@JoshuaKGoldberg JoshuaKGoldberg added area: repository tooling concerning ease of contribution and removed area: qa labels Jan 2, 2024
@JoshuaKGoldberg
Copy link
Member

This is very old and has some merge conflicts. Closing out as we'll separately investigate better development-time types support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outsideris outsideris outsideris approved these changes

Assignees
No one assigned
Labels
area: repository tooling concerning ease of contribution semver-patch implementation requires increase of "patch" version number; "bug fixes" type: chore generally involving deps, tooling, configuration, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@boneskull @coveralls @JoshuaKGoldberg @outsideris