Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yk_iter function #10

Merged
merged 17 commits into from
Jun 18, 2023
Merged

yk_iter function #10

merged 17 commits into from
Jun 18, 2023

Conversation

mdorier
Copy link
Collaborator

@mdorier mdorier commented Jun 15, 2023

TODO

  • Implement iter function for all the backends
  • C++ API
  • Python API
  • Python test

src/backends/map.cpp Fixed Show fixed Hide fixed
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #10 (937baed) into main (e8214f6) will increase coverage by 1.32%.
The diff coverage is 77.38%.

@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
+ Coverage   73.15%   74.48%   +1.32%     
==========================================
  Files          93       95       +2     
  Lines       10572    11067     +495     
  Branches     1469     1529      +60     
==========================================
+ Hits         7734     8243     +509     
+ Misses       2240     2168      -72     
- Partials      598      656      +58     
Impacted Files Coverage Δ
include/yokan/database.h 100.00% <ø> (ø)
include/yokan/filters.hpp 100.00% <ø> (ø)
src/backends/unqlite.cpp 67.15% <ø> (+24.23%) ⬆️
src/client/fetch.cpp 91.90% <ø> (ø)
src/server/provider.hpp 100.00% <ø> (ø)
src/server/util/filters.cpp 52.66% <25.00%> (-2.90%) ⬇️
src/backends/lmdb.cpp 63.43% <44.11%> (-2.75%) ⬇️
src/backends/leveldb.cpp 76.39% <71.87%> (-0.42%) ⬇️
src/backends/rocksdb.cpp 64.70% <71.87%> (+0.46%) ⬆️
src/backends/berkeleydb.cpp 77.48% <72.58%> (-0.78%) ⬇️
... and 10 more

... and 1 file with indirect coverage changes

@@ -812,6 +812,113 @@
return Status::OK;
}


Status iter(int32_t mode, uint64_t max, const UserMem& fromKey,

Check warning

Code scanning / CodeQL

Poorly documented large function

Poorly documented function: fewer than 2% comments for a function of 105 lines.
@mdorier mdorier merged commit 357ccef into main Jun 18, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant