Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev doc iter #12

Merged
merged 10 commits into from
Jun 21, 2023
Merged

Dev doc iter #12

merged 10 commits into from
Jun 21, 2023

Conversation

mdorier
Copy link
Collaborator

@mdorier mdorier commented Jun 20, 2023

No description provided.

start_id += g_items_per_op;
}

for(uint64_t i=0; i < result.recv_ids.size(); i++) {

Check notice

Code scanning / CodeQL

Declaration hides variable

Variable i hides another variable of the same name (on [line 151](1)).

munit_assert_size(result.recv_ids.size(), ==, context->reference.size());

for(uint64_t i=0; i < result.recv_ids.size(); i++) {

Check notice

Code scanning / CodeQL

Declaration hides variable

Variable i hides another variable of the same name (on [line 78](1)).
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #12 (269827f) into main (357ccef) will increase coverage by 0.66%.
The diff coverage is 91.53%.

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   74.50%   75.16%   +0.66%     
==========================================
  Files          95       97       +2     
  Lines       11067    11433     +366     
  Branches     1529     1563      +34     
==========================================
+ Hits         8245     8594     +349     
- Misses       2167     2178      +11     
- Partials      655      661       +6     
Impacted Files Coverage Δ
include/yokan/filters.hpp 100.00% <ø> (ø)
src/server/provider.hpp 100.00% <ø> (ø)
include/yokan/doc-mixin.hpp 73.66% <74.07%> (-0.17%) ⬇️
python/py-yokan-client.cpp 83.77% <76.47%> (-0.20%) ⬇️
src/server/util/filters.cpp 55.91% <88.88%> (+3.25%) ⬆️
src/client/doc_iter.cpp 93.38% <93.38%> (ø)
src/server/doc_iter.cpp 93.86% <93.86%> (ø)
include/yokan/backend.hpp 67.12% <100.00%> (+0.92%) ⬆️
include/yokan/cxx/collection.hpp 91.07% <100.00%> (+0.87%) ⬆️
src/client/client.cpp 74.15% <100.00%> (+1.21%) ⬆️
... and 1 more

... and 1 file with indirect coverage changes

@mdorier mdorier merged commit ca920d6 into main Jun 21, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant