Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Krastorio loaders #156

Closed

Conversation

ExE-Boss
Copy link

@ExE-Boss ExE-Boss commented Jan 4, 2024

This adds basic compatibility for Krastorio’s loaders and also fixes the Fast and Express inserter recipes when K2+SE is present.

I chose not to add Basic Loaders, as Krastorio loaders are unlocked from the same research as the belt and only need electricity to operate, so it doesn’t make as much sense to add those as it does with AAI Loaders, which use fluids to operate.

Related issues

@ExE-Boss ExE-Boss force-pushed the feat/logistics/krastorio-loaders branch from 221787e to 358cfdb Compare January 5, 2024 12:05
@KiwiHawk
Copy link
Contributor

KiwiHawk commented Jan 6, 2024

Krastorio2 already has purple and green tier loaders (as well as matching belts, undergrounds, and splitters).

image

image

Rather than creating additional new entities, I think it would be best to use the existing ones:

  • Hide these entities and recipes
    • Turbo Transport Belt
    • Turbo Underground Belt
    • Turbo Splitter
    • Ultimate Transport Belt
    • Ultimate Underground Belt
    • Ultimate Splitter
  • Update the underground distance on the following (make sure the underground distance is >= previous so there's no issue with replacing):
    • Advanced Underground Belt: Max underground distance of Advanced Underground Belt / Turbo Underground Belt
    • Superior Underground Belt: Max underground distance of Superior Underground Belt / Ultimate Underground Belt
  • Update the subgroup for the following so they line up with Bob's:
    • Advanced Transport Belt
    • Superior Transport Belt
    • Advanced Underground Belt
    • Superior Underground Belt
    • Advanced Splitter
    • Superior Splitter
    • Loader
    • Fast Loader
    • Express Loader
    • Advanced Loader
    • Superior Loader
  • Hide the following Bob's techs. Update anything that has it as a prerequisite to use the Krastorio 2 version:
    • Logistics 4
    • Logistics 5
  • Add migration file to replace the following items / recipes / entities:
    • Turbo Transport Belt => Advanced Transport Belt
    • Ultimate Transport Belt => Superior Transport Belt
    • Turbo Underground Belt => Advanced Underground Belt
    • Ultimate Underground Belt => Superior Underground Belt
    • Turbo Splitter => Advanced Splitter
    • Ultimate Splitter => Superior Splitter

@KiwiHawk KiwiHawk assigned KiwiHawk and ExE-Boss and unassigned KiwiHawk Jan 6, 2024
@KiwiHawk KiwiHawk removed this from the Bob's mods 1.2.1 milestone Jan 6, 2024
@KiwiHawk KiwiHawk marked this pull request as draft January 6, 2024 05:34
@Qatavin
Copy link
Contributor

Qatavin commented Jan 9, 2024

We could go with either the Bob's two top tiers of belts or the K2 belts, but I think sticking with the Bob's belts would be best. That would be more convenient for the setting that allows you to change the speeds of the belts, and it would keep the colors consistent with the inserters and everything else, since K2 belts go green and then purple instead of purple and then green.

It should still not be necessary to generate new loaders, though. It would work just as well to repurpose the current K2 ones by swapping their graphics and adjusting them so their speeds match whatever the Bob's belts have (since their speed is adjustable).

@KiwiHawk
Copy link
Contributor

KiwiHawk commented Jan 9, 2024

Yes, that also works.

Placed underground belts are one of the more difficult things to migrate as their reach may have decreased.
Instead of replacing
existing placed undergrounds, it might be safer to leave them in place and instead set the mining result to be the version that is being kept.

@Qatavin
Copy link
Contributor

Qatavin commented Feb 8, 2024

All of this has been taken care of by my new B+SE+K2 mod as well. (But doing something with K2 loaders in base Bob's Logistics would not be any kind of issue)

@ExE-Boss ExE-Boss closed this Feb 8, 2024
@ExE-Boss ExE-Boss reopened this Feb 8, 2024
@KiwiHawk KiwiHawk closed this Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants