Remove signals too close to zero in MultiBody reference files #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r multi-body systems, because the CSV compare tool cannot reliably test them
15 tasks
beutlich
reviewed
Jun 18, 2024
|
You are right, sorry. This process is really awfully complicated, if you don't do it every other day... 😅 |
|
Done properly in modelica/ModelicaStandardLibrary#4420 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In modelica/ModelicaStandardLibrary#4341 some regressions between 4.0.0 and 4.1.0 were reported, which were due to reference signals being very close to zero. The CSV compare tool cannot reliably test them, since it asks, e.g., for a precision of 1e-14 in a component of a quaternion that has order of magnitude 1. Unfortunately, there is currently no means to specify a reference magnitude for such signals, so the only way to avoid spurious regressions, also in the future, is to remove those signals.