Separate out external object files #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikt-ma
reviewed
Aug 26, 2024
henrikt-ma
reviewed
Oct 1, 2024
| @@ -0,0 +1,15 @@ | |||
| #include "ExtObj.h" | |||
|
|
|||
| #include <stdio.h> | |||
There was a problem hiding this comment.
Why is stdio.h included everywhere?
henrikt-ma
reviewed
Oct 1, 2024
| @@ -4,21 +4,24 @@ model ExternalObjectTableInFunction | |||
| extends Icons.TestCase; | |||
|
|
|||
| class MyTable | |||
| // Note that this is a copy of ModelicaCompliance.Functions.ExternalObjects.ExternalTable | |||
There was a problem hiding this comment.
I can't see that class, did you mean this?
Suggested change
| // Note that this is a copy of ModelicaCompliance.Functions.ExternalObjects.ExternalTable | |
| // Note that this is a copy of ModelicaCompliance.Functions.ExternalObjects.ExternalObjectTable |
henrikt-ma
suggested changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a replacement for #74
To me it makes more sense that each Modelica function includes one C-function; than each of them brings all of them requiring them to be static.