Added missing experiment annotations #4516
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casella
requested review from
maltelenz,
christiankral,
AHaumer and
HansOlsson
|
I don't feel comfortable reviewing this, given that I have little to no experience in this domain. |
HansOlsson
reviewed
Jan 7, 2025
| @@ -226,5 +226,6 @@ package Polyphase "Polyphase quasi-static package" | |||
| connect(starI.plug_p,currentSource. plug_p) annotation (Line(points={{-20,-80},{-20,-50}}, color={85,170,255})); | |||
| connect(currentSource.plug_p, capacitor.plug_n) annotation (Line(points={{-20,-50},{-10,-50},{-10,-20},{-20,-20}}, color={85,170,255})); | |||
| connect(capacitor.plug_p,currentSource. plug_n) annotation (Line(points={{-40,-20},{-50,-20},{-50,-50},{-40,-50}}, color={85,170,255})); | |||
| annotation(experiment(StopTime = 1.0, Interval = 0.0002)); | |||
There was a problem hiding this comment.
Suggested change
| annotation(experiment(StopTime = 1.0, Interval = 0.0002)); | |
| annotation(experiment(StopTime = 1.0)); |
I don't see a need for Interval, as the other examples in the same package doesn't have it and still has the same number of outputs, and there is nothing interesting in these signals at that time-scale. I guess the added points are added to make the references "better" in some way.
HansOlsson
reviewed
Jan 7, 2025
| @@ -265,5 +265,6 @@ package SinglePhase "Single-phase quasi-static package" | |||
| connect(currentCurrent.pin_p, impedanceC.pin_n) annotation (Line(points={{20,-50},{20,-60},{50,-60},{50,-50}}, color={85,170,255})); | |||
| connect(groundI1.pin, currentCurrent.pin_p) annotation (Line(points={{0,-60},{20,-60},{20,-50}}, color={85,170,255})); | |||
| connect(complexRampC.y, impedanceC.Z_ref) annotation (Line(points={{69,-40},{62,-40}}, color={85,170,255})); | |||
| annotation(experiment(StopTime = 1.0, Interval = 0.0002)); | |||
There was a problem hiding this comment.
Suggested change
| annotation(experiment(StopTime = 1.0, Interval = 0.0002)); | |
| annotation(experiment(StopTime = 1.0)); |
I don't see a need for Interval, as the other examples in the same package doesn't have it and still has the same number of outputs, and there is nothing interesting in these signals at that time-scale. I guess the added points are added to make the references "better" in some way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4510.
If approved should be ported to maint/4.1.x