Add missing experiment annotations #4516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casella
requested review from
maltelenz,
christiankral,
AHaumer and
HansOlsson
|
I don't feel comfortable reviewing this, given that I have little to no experience in this domain. |
HansOlsson
reviewed
Jan 7, 2025
HansOlsson
reviewed
Jan 7, 2025
beutlich
changed the title
beutlich
added
the
L: ModelicaTest
Co-authored-by: Hans Olsson <[email protected]>
Co-authored-by: Hans Olsson <[email protected]>
HansOlsson
approved these changes
Jan 21, 2025
|
@maltelenz please back-port it to maint/4.1.x once merged in. |
maltelenz
pushed a commit
to maltelenz/ModelicaStandardLibrary
that referenced
this pull request
Jan 21, 2025
* Added missing experiment annotations. Fixes modelica#4510 * Update ModelicaTest/Electrical/QuasiStatic/Polyphase.mo Co-authored-by: Hans Olsson <[email protected]> * Update ModelicaTest/Electrical/QuasiStatic/SinglePhase.mo Co-authored-by: Hans Olsson <[email protected]> --------- Co-authored-by: Hans Olsson <[email protected]> (cherry picked from commit ff95fea)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4510.
If approved should be ported to maint/4.1.x