Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MODELIX-865: Improve logging #1089

Merged
merged 2 commits into from
Sep 26, 2024
Merged

MODELIX-865: Improve logging #1089

merged 2 commits into from
Sep 26, 2024

Conversation

languitar
Copy link
Contributor

  • Adds the branch name to the in-memory model loading messages for better tracing
  • Enables call logging to support tracing individual requests on the model-server.

To be verified by reviewers

  • Relevant public API members have been documented
  • Documentation related to this PR is complete
    • Boundary conditions are documented
    • Exceptions are documented
    • Nullability is documented if used
  • Touched existing code has been extended with documentation if missing
  • Code is readable
  • New features and fixed bugs are covered by tests

@languitar
feat(model-server): log which branch is loaded to in-memory model
96afad5 
This makes debugging a bit easier.
@languitar
feat(model-server): enable call logging
1a07356 
This makes it possible to trace individual requests and to see their
response times.
@languitar languitar requested review from slisson and a team as code owners September 26, 2024 08:44
@languitar languitar changed the title Improve loggig Improve logging Sep 26, 2024
@languitar languitar changed the title Improve logging MODELIX-865: Improve logging Sep 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

Test Results

  178 files    178 suites   23m 9s ⏱️
1 008 tests 1 001 ✅ 7 💤 0 ❌
1 018 runs  1 011 ✅ 7 💤 0 ❌

Results for commit 1a07356.

@github-actions GitHub Actions
Copy link
Contributor

JVM coverage report

Overall Project 53.84% -0.04% ❌
Files changed 25.4% ❌

File Coverage
InMemoryModel.kt 42.99% 🍏
Main.kt 18.83% -4.89% ❌

@languitar languitar merged commit f3cce73 into main Sep 26, 2024
19 checks passed
@languitar languitar deleted the feature/improve-logging branch September 26, 2024 09:04
@slisson
Copy link
Member

slisson commented Sep 27, 2024

🎉 This PR is included in version 9.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odzhychko odzhychko odzhychko approved these changes

@slisson slisson Awaiting requested review from slisson slisson is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@languitar @slisson @odzhychko