Include legacy-* permissions in admin permission #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Legacy permissions (used by model client V1) were not included in the admin permission.
|
There are more locations where it is missing. Let's check for more inconsistencies and fix all of them. |
benedekh
force-pushed
the
fix/legacy-permissions-are-not-in-admin-permission
branch
from
6bdfd09
to
7e3673c
Compare
Test Results53 tests 53 ✅ 20s ⏱️ Results for commit 7e3673c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legacy permissions (used by model client V1) were not included in the admin permission.
To be verified by reviewers