Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ut #456

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Fix ut #456

merged 3 commits into from
Oct 8, 2024

Conversation

rayrayraykk
Copy link
Collaborator

@rayrayraykk rayrayraykk commented Oct 8, 2024 •
edited
Loading

UT might fail when network error happens, which will contain str type in ServiceResponse.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@rayrayraykk rayrayraykk changed the title [WIP] Fix ut Fix ut Oct 8, 2024
pan-x-c
pan-x-c approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@pan-x-c pan-x-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pan-x-c pan-x-c merged commit 9d7af22 into modelscope:main Oct 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pan-x-c pan-x-c pan-x-c approved these changes

@DavdGao DavdGao Awaiting requested review from DavdGao

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rayrayraykk @pan-x-c