Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct num_proc logic #365

Merged
merged 4 commits into from
Jul 26, 2024
Merged

correct num_proc logic #365

merged 4 commits into from
Jul 26, 2024

Conversation

drcege
Copy link
Collaborator

@drcege drcege commented Jul 24, 2024

Currently, when OP-specific num_proc argument is not set, it will not automatically fall back to global np.

  • This is a bug accidentally introduced in a previous commit, now fixed
  • Also, fix an edge case where the rank is None in the OCR operator when np=1

@drcege drcege added the bug Something isn't working label Jul 24, 2024
@drcege drcege self-assigned this Jul 24, 2024
@drcege drcege added the priority:high in high priority label Jul 24, 2024
@garyzhang99
Copy link
Collaborator

In the previous refactor PR #359, we set all op's ray mode to task, which will cause CUDA OOM error.
We need to add back ray actor mode for op that use gpu.

@drcege drcege merged commit 2271feb into main Jul 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:high in high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants