use pydantic types #422
Merged
use pydantic types #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drcege
force-pushed
the
enhance/type_hints
branch
from
1dec740
to
e68d66e
Compare
drcege
added a commit
that referenced
this pull request
Sep 13, 2024
* temp * Regress model preloading (#426) * fix param definition (#424) * fix param def * add param check * use pydantic types (#422) * use pydantic types * change config unittest * fix GenerateInstructionMapper * update * Fix (#427) Fix some words * Add new OP: image_tagging_mapper (#423) * * init image tagging mapper * + Add unittest for image_tagging_mapper * support specified tag field names for all tagging OPs * * fix problems of unittest * + add docs * * update docs * * skip two unittests which require ram * * minor fix for gece's comments * * merge main into this branch * + add type hint * match api call * match api call * pre-commit * decouple API args & add type hints --------- Co-authored-by: Ce Ge (戈策) <[email protected]> Co-authored-by: Cathy0908 <[email protected]> Co-authored-by: co63oc <[email protected]> Co-authored-by: Yilun Huang <[email protected]> Co-authored-by: null <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tuple[str]orTuple[int]was used incorrectly. They indicate that the tuple can only contain a single element, which differs fromList[str]orList[int], which are variable-length sequences by default. After the modification:List, which can be correctly recognized and converted by Pydantic from compatible types liketuple,list,set,frozenset,deque, etc. refTupleonly when the length of the sequence is fixed, such as a pair of coordinates that always has a length of 2.Refactor all type annotations from
jsonargparsetoPydantic.