Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

* fix pre-commit failures and add pre-commit action #68

Merged
merged 7 commits into from
Nov 14, 2023
Merged

* fix pre-commit failures and add pre-commit action #68

merged 7 commits into from
Nov 14, 2023

Conversation

HYLcool
Copy link
Collaborator

@HYLcool HYLcool commented Nov 13, 2023 •
edited
Loading

  • fix pre-commit failures
  • add pre-commit action: it's better to apply pre-commit check locally before pushing to the remote repo.
  • update isort version to the latest to avoid inconsistency in different envs.

@HYLcool HYLcool added the enhancement New feature or request label Nov 13, 2023
@HYLcool HYLcool self-assigned this Nov 13, 2023
@HYLcool HYLcool linked an issue Nov 13, 2023 that may be closed by this pull request
[fix] pre-commit problems fixing #67
Closed
yxdyc
yxdyc approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@yxdyc yxdyc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some doc for the PR in this commit, please @HYLcool double check it. Others look good to me!

@HYLcool
Copy link
Collaborator Author

HYLcool commented Nov 14, 2023

All local tests on different environments (My mac/ubuntu/dev envs of @yxdyc, @zhijianma, and @chenhesen) are passed~🎉

@HYLcool HYLcool merged commit db59995 into main Nov 14, 2023
5 checks passed
@HYLcool HYLcool deleted the fix/pre_commit_format_check branch November 14, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxdyc yxdyc yxdyc approved these changes

@chenhesen chenhesen Awaiting requested review from chenhesen

@zhijianma zhijianma Awaiting requested review from zhijianma

Assignees

@HYLcool HYLcool

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] pre-commit problems fixing
2 participants
@HYLcool @yxdyc