Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parse5-utils): add support for templates in findNode #2751

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

WillsonSmith
Copy link
Contributor

What I did

  1. Add a shared helper function for findNode and findNodes to find child nodes within <template> elements
  2. Enable findNode to find children within a <template> element
  3. Add a test for findNode

This expands on #2398 which added this functionality to findNodes.

Copies logic from findNodes and applies it to findNode.
Extract the <template> finding logic to a shared helper function.
Copy link

changeset-bot bot commented Jun 7, 2024

🦋 Changeset detected

Latest commit: 87afd9a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web/parse5-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@Westbrook Westbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for normalizing this!

@WillsonSmith
Copy link
Contributor Author

Always happy to contribute, thanks for taking the time to review this! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants