[feature] Added a CLI flag to allow passing without any test files found #2758
Conversation
🦋 Changeset detectedLatest commit: dcaff84 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Could you add a change set as requested above? |
|
I will add one after work today. |
|
Changeset added, @Westbrook. I think the bot's comment is completely out to lunch now, though, because of the merge commit in a957ff9. |
|
Thanks for getting the changeset it. That is looking fine. Can you check in the CI output? Once that’s green we should be good to edge this. |
|
Will take a look tonight! |
| } | ||
| finalConfig.files = undefined; | ||
| finalConfig.allowPassWithoutTests = undefined; |
There was a problem hiding this comment.
what is the reason to set it as undefined? isn't it more clear to have it always as a boolean and default to false?
| @@ -27,6 +27,7 @@ export interface CoverageConfig { | |||
| export interface TestRunnerCoreConfig { | |||
| rootDir: string; | |||
| files?: string | string[]; | |||
| allowPassWithoutTests?: boolean; | |||
There was a problem hiding this comment.
related to another question: I'd just make it allowPassWithoutTests: boolean and default to "false", here and below
What I did
.envrc).Would resolve #1331