Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF-#6629: HDK: Avoid LazyProxyCategoricalDtype materialization on merge #6630

Merged
merged 3 commits into from
Oct 6, 2023
Merged

PERF-#6629: HDK: Avoid LazyProxyCategoricalDtype materialization on merge #6630

merged 3 commits into from
Oct 6, 2023

Conversation

AndreyPavlenko
Copy link
Collaborator

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves PERF: HDK triggers LazyProxyCategoricalDtype materialization on merge #6629
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@AndreyPavlenko AndreyPavlenko marked this pull request as ready for review October 4, 2023 17:41
@AndreyPavlenko AndreyPavlenko requested a review from a team as a code owner October 4, 2023 17:41
@AndreyPavlenko AndreyPavlenko requested a review from a team as a code owner October 5, 2023 11:58
@AndreyPavlenko
Apply suggestions from code review
3380d3d 
Signed-off-by: Andrey Pavlenko <[email protected]>
dchigarev
dchigarev previously approved these changes Oct 5, 2023
View reviewed changes
@AndreyPavlenko
Apply suggestions from code review
e008a43 
Signed-off-by: Andrey Pavlenko <[email protected]>
@dchigarev dchigarev merged commit 205a170 into modin-project:master Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchigarev dchigarev dchigarev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PERF: HDK triggers LazyProxyCategoricalDtype materialization on merge
2 participants
@AndreyPavlenko @dchigarev