Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF-#6645: avoid label synchronization for dot operation #6644

Merged
merged 2 commits into from
Oct 16, 2023
Merged

PERF-#6645: avoid label synchronization for dot operation #6644

merged 2 commits into from
Oct 16, 2023

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Oct 12, 2023 •
edited
Loading

What do these changes do?

Manually aligning indexes is much cheaper than using sync_label option, which creates a copy for each partition with an updated index (lazy map operation).

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Avoid label synchronization for dot operation #6645
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev anmyachev changed the title PERF-#0000: avoid label synchronization for dot operation PERF-#56645: avoid label synchronization for dot operation Oct 12, 2023
@anmyachev anmyachev changed the title PERF-#56645: avoid label synchronization for dot operation PERF-#6645: avoid label synchronization for dot operation Oct 12, 2023
@anmyachev anmyachev marked this pull request as ready for review October 12, 2023 17:42
@anmyachev anmyachev requested a review from a team as a code owner October 12, 2023 17:42
@anmyachev anmyachev requested a review from dchigarev October 12, 2023 18:59
@anmyachev anmyachev mentioned this pull request Oct 13, 2023
Open
3 tasks
dchigarev
dchigarev previously approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@dchigarev dchigarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

modin/core/storage_formats/pandas/query_compiler.py Show resolved Hide resolved
@anmyachev
Copy link
Collaborator Author

@dchigarev let's merge

@dchigarev dchigarev merged commit f14b0fe into modin-project:master Oct 16, 2023
37 checks passed
@anmyachev anmyachev deleted the dot-perf branch October 16, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchigarev dchigarev dchigarev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid label synchronization for dot operation
2 participants
@anmyachev @dchigarev