Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-#6647: Added init file to make modin/experimental/sql/hdk/query.py part of modin package #6646

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

Egor-Krivov
Copy link
Contributor

@Egor-Krivov Egor-Krivov commented Oct 13, 2023

By making a contribution to this project, I certify that:

1.) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or 2.) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or 3.) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. 4.) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

What do these changes do?

This file is currently not part of modin package (for example, here in source files . To fix that we add __init__.py file to turn folder into normal python module.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BUG: modin.experimental.sql.hdk.query is not part of modin package #6647
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

By making a contribution to this project, I certify that:

1.) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or 2.) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or 3.) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. 4.) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

Signed-off-by: Egor Krivov <[email protected]>
@Egor-Krivov Egor-Krivov requested a review from a team as a code owner October 13, 2023 10:54
@dchigarev
Copy link
Collaborator

dchigarev commented Oct 13, 2023

Thanks for the fix!

Although, each file (even an empty one) requires the license thing and sometimes a brief one-line docstring, otherwise CI won't pass I believe

Example:
https://github.com/modin-project/modin/blob/master/modin/core/dataframe/__init__.py

@Egor-Krivov Egor-Krivov changed the title Added init file to make modin/experimental/sql/hdk/query.py part of modin package BUG-#6647: Added init file to make modin/experimental/sql/hdk/query.py part of modin package Oct 13, 2023
@Egor-Krivov
Copy link
Contributor Author

Changed title to fit modin requirements and created issue

@dchigarev dchigarev merged commit ce54013 into modin-project:master Oct 13, 2023
@dchigarev dchigarev changed the title BUG-#6647: Added init file to make modin/experimental/sql/hdk/query.py part of modin package FIX-#6647: Added init file to make modin/experimental/sql/hdk/query.py part of modin package Oct 13, 2023
anmyachev pushed a commit to anmyachev/modin that referenced this pull request Oct 30, 2023
…l/hdk/query.py part of modin package (modin-project#6646)

Signed-off-by: Egor Krivov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: modin.experimental.sql.hdk.query is not part of modin package
2 participants