Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-#0000: follow up PR with fixes for #5634 #6652

Closed
wants to merge 2 commits into from

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Oct 16, 2023

What do these changes do?

#6650

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves #?
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev anmyachev marked this pull request as ready for review October 16, 2023 19:12
@anmyachev anmyachev requested a review from a team as a code owner October 16, 2023 19:12
@anmyachev
Copy link
Collaborator Author

@YarShev

@anmyachev anmyachev marked this pull request as draft October 17, 2023 13:32
@@ -302,7 +301,7 @@ def ip(self, materialize=True):
if len(self.call_queue):
self.drain_call_queue()
else:
self._ip_cache = self.apply(lambda df: pandas.DataFrame([]))._ip_cache
self._ip_cache = self.apply(lambda df: None)._ip_cache
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a cluster, this may not be correct, since if all the processes of one node are busy, then the engine can start the calculation on another node, which will lead to incorrect receipt of the address.

One of the most likely solutions would be to return the entire dataframe and completely update the partition (all references to remote objects).

It may potentially be possible to use special API engines to obtain the address more efficiently. (for example, like in ray-project/ray#13630)

@YarShev thanks for the explanation and solution proposal!

@anmyachev anmyachev closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant