FIX-#6651: make sure Series.between works correctly
#6656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatoly Myachev <[email protected]>
dchigarev
reviewed
Oct 17, 2023
modin/pandas/series.py
Outdated
Comment on lines
721
to
725
| return self.__constructor__( | ||
| query_compiler=self._query_compiler.between(left, right, inclusive) | ||
| query_compiler=self._query_compiler.between( | ||
| left=left, right=right, inclusive=inclusive | ||
| ) | ||
| ) |
There was a problem hiding this comment.
it looks like the logic of this method can be easily implemented at the front end, I believe we don't need to add this new qc method.
We can either copy the pandas' logic or just pass our own object to the pandas method:
def between(self, left, right, inclusive):
# 'pandas.between()' only uses public Series' API, so passing a Modin Series there is safe
return pandas.Series.between(self, left, right, inclusive)There was a problem hiding this comment.
Interesting! Let's try.
Signed-off-by: Anatoly Myachev <[email protected]> Co-authored-by: Dmitry Chigarev <[email protected]>
dchigarev
approved these changes
Oct 17, 2023
|
@dchigarev let's merge |
YarShev
reviewed
Oct 18, 2023
| ) | ||
| # 'pandas.Series.between()' only uses public Series' API, | ||
| # so passing a Modin Series there is safe | ||
| return pandas.Series.between(self, left, right, inclusive) |
There was a problem hiding this comment.
I wouldn't rely on pandas to handle Modin objects properly. We should probably pass a pandas Series or a numpy array in to the method.
anmyachev
added a commit
to anmyachev/modin
that referenced
this pull request
Oct 30, 2023
…odin-project#6656) Signed-off-by: Anatoly Myachev <[email protected]> Co-authored-by: Dmitry Chigarev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date