Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERF-#6702: don't materialize axes when calling to_numpy #6699

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Nov 3, 2023

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Don't materialize axes when calling to_numpy #6702
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev anmyachev changed the title PERF-#0000: don't materialize axes when calling to_numpy PERF-#6702: don't materialize axes when calling to_numpy Nov 3, 2023
Copy link
Collaborator

@dchigarev dchigarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the obvious thing to mention is that we are losing the ability to catch errors when index/columns are not materialized, but I guess it's okay?

@anmyachev
Copy link
Collaborator Author

the obvious thing to mention is that we are losing the ability to catch errors when index/columns are not materialized, but I guess it's okay?

Not really, when the index is not materialized, we calculate it from internal partitions, in this case the check does not make sense. We do the same for to_pandas.

@anmyachev
Copy link
Collaborator Author

@dchigarev let's merge it

@dchigarev dchigarev merged commit 0c68d9f into modin-project:master Nov 6, 2023
37 checks passed
@anmyachev anmyachev deleted the to-numpy branch November 6, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't materialize axes when calling to_numpy
2 participants