Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF-#6718: Use _get_axis_lengths func instead of _axes_lengths property #6719

Merged
merged 1 commit into from
Nov 7, 2023
Merged

PERF-#6718: Use _get_axis_lengths func instead of _axes_lengths property #6719

merged 1 commit into from
Nov 7, 2023

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Nov 7, 2023 •
edited
Loading

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Reimplement the _axes_lengths property to avoid materializing both axes at the same time #6718
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev anmyachev marked this pull request as ready for review November 7, 2023 12:22
@dchigarev dchigarev merged commit 90ec679 into modin-project:master Nov 7, 2023
37 checks passed
@anmyachev anmyachev deleted the issue6718 branch November 7, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchigarev dchigarev dchigarev approved these changes

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@YarShev YarShev Awaiting requested review from YarShev YarShev is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reimplement the _axes_lengths property to avoid materializing both axes at the same time
2 participants
@anmyachev @dchigarev