Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-#6781: Use pandas.api.types.pandas_dtype to convert to valid numpy and pandas only dtypes #6788

Merged
merged 5 commits into from
Dec 1, 2023

Conversation

JignyasAnand
Copy link
Contributor

@JignyasAnand JignyasAnand commented Nov 30, 2023

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves TypeError: data type 'Int64' not understood #6781
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev
Copy link
Collaborator

@JignyasAnand thanks for the contribution! Could you also add a test using code from the issue somewhere around?

def test_sum(data, axis, skipna, is_transposed):

@JignyasAnand
Copy link
Contributor Author

Hi @anmyachev . I have added the tests. Can you take a look at them?

Signed-off-by: JignyasAnand <[email protected]>
Copy link
Collaborator

@anmyachev anmyachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anmyachev anmyachev merged commit 68c69f8 into modin-project:master Dec 1, 2023
37 checks passed
@anmyachev
Copy link
Collaborator

Thanks @JignyasAnand!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: data type 'Int64' not understood
3 participants