Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#7170: Don't use MinPartitionSize configuration variable in remote context #7177

Merged
merged 8 commits into from
Apr 15, 2024
Merged

FIX-#7170: Don't use MinPartitionSize configuration variable in remote context #7177

merged 8 commits into from
Apr 15, 2024

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Apr 11, 2024 •
edited
Loading

What do these changes do?

The problem is that setting a new value for configuration variables is not automatically propagated to all Modin processes.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BUG: Calling df._repartition(axis=1) on updated df will raise IndexError #7170
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev
FIX-modin-project#7170: Don't use 'MinPartitionSize' configuration va…
b9b6a83 
…riable in remote context

Signed-off-by: Anatoly Myachev <[email protected]>
@anmyachev
fix
7553077 
Signed-off-by: Anatoly Myachev <[email protected]>
@anmyachev
add a test
be26a1a 
Signed-off-by: Anatoly Myachev <[email protected]>
@anmyachev
fixes
40b5569 
Signed-off-by: Anatoly Myachev <[email protected]>
@anmyachev
fix
b589d27 
Signed-off-by: Anatoly Myachev <[email protected]>
@anmyachev
fix
f68e1e4 
Signed-off-by: Anatoly Myachev <[email protected]>
@anmyachev
fix
c7db2a6 
Signed-off-by: Anatoly Myachev <[email protected]>
@anmyachev
fix
31cda2b 
Signed-off-by: Anatoly Myachev <[email protected]>
@anmyachev anmyachev marked this pull request as ready for review April 12, 2024 17:42
@YarShev YarShev merged commit 7b233e4 into modin-project:master Apr 15, 2024
53 checks passed
@anmyachev anmyachev deleted the issue7170 branch April 15, 2024 10:38
@korbit-ai korbit-ai bot mentioned this pull request Aug 13, 2024
Open
7 tasks
@local-dev-korbit-ai-mentor local-dev-korbit-ai-mentor bot mentioned this pull request Aug 15, 2024
Open
7 tasks
@korbit-ai korbit-ai bot mentioned this pull request Aug 15, 2024
Open
7 tasks
@local-dev-korbit-ai-mentor local-dev-korbit-ai-mentor bot mentioned this pull request Aug 15, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

@dchigarev dchigarev Awaiting requested review from dchigarev dchigarev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Calling df._repartition(axis=1) on updated df will raise IndexError
2 participants
@anmyachev @YarShev