-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT-#7368: Add a new environment variable for using dynamic partitioning #7369
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -30,6 +30,7 @@ | |||||
from modin.config import ( | ||||||
BenchmarkMode, | ||||||
CpuCount, | ||||||
DynamicPartitioning, | ||||||
Engine, | ||||||
MinColumnPartitionSize, | ||||||
MinRowPartitionSize, | ||||||
|
@@ -675,7 +676,7 @@ def map_partitions( | |||||
NumPy array | ||||||
An array of partitions | ||||||
""" | ||||||
if np.prod(partitions.shape) <= 1.5 * CpuCount.get(): | ||||||
if not DynamicPartitioning.get(): | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would be good to keep the previous default behavior.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you think we should do that? Shouldn't the user be given more freedom to decide when to activate this option? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The user now has the ability to force the use of another code branch at his own choice, this is already more flexibility than before. And since this condition worked quite well before and considering that slowdowns are possible when using this new variable, I would replace the default behavior more carefully. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Confused with similar code in |
||||||
# block-wise map | ||||||
new_partitions = cls.base_map_partitions( | ||||||
partitions, map_func, func_args, func_kwargs | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we plan to look for a heuristic that can switch implementations automatically, then we could add a few words about this (and a link to the issue).