Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drawBitmap method to ColorGraphicsDisplay interface #831

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mcbridejc
Copy link
Contributor

Hey want to solicit thoughts on this change, or something like it, @TomSaw, @salkinium.

The ILI9341 driver offers a drawBitmap method, which can take a an Rgb565 bitmap as input, but this is not in the ColorGraphicsDisplay interface, and that's a problem because the ILI9341 has many template arguments so it's awkward to pass a reference to it.

Should we just add this virtual method to ColorGraphicsDisplay?

@salkinium
Copy link
Member

I guess? I don't really have an overview anymore over the graphics API, so I'm delegating this to our expert @TomSaw

@TomSaw
Copy link
Contributor

TomSaw commented Feb 22, 2022

Hey @mcbridejc. I'm sitting on a complete rewrite of the graphic APIs since 2021.
The new architecture is quite flexible and should solve your issue:
It allows copying+converting a bitmap in any imaginable colorspace (f.e. RGB565) stored somewhere (f.e. in flash memory) to any other writable memory in any imaginable colorspace, be it the local RAM or the displays CGRAM.

See these these dependent PRs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants