Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

fix: ignore loader for file update if not applicable #951

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ToBinio
Copy link

@ToBinio ToBinio commented Aug 15, 2024

currently, the App has no way of knowing what type of project it requests an update for. so it always includes the launcher.
For projects that do not support this launcher (e.g Resourcepacks don't support fabric) this causes no version update to be sent and the app and the app not being able to update e.g Resourcepacks

this can be seen here: https://reqbin.com/hlipjykw (request update for freshAnimations 1.9.1 ) which should have an update but does not return one.
removing fabric from the request fixes this.

Important

I was not able to test if this code really works since it is a pain to get labrinth running with test data.
Please verify the functionality by using the post request from above and seeing the same result with and without fabric

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant