Skip to content

Commit

Permalink
[FIX] l10n_fr_siret[_lookup]: remove wrong dependency
Browse files Browse the repository at this point in the history
Odoo 16 depends on both requests and python-stdnum, so there's no need to specify those dependencies.

Besides, [python-stdnum is pinned to 1.16][1]. Thus, when applying OCA/oca-ci#66 locally, the constraint failed. OCA addons should work with the dependencies pinned upstream.

[1]: https://github.com/odoo/odoo/blob/fe4d8e8014e50d4335e0a8b052b5098f3a79bcec/requirements.txt#L48

@moduon MT-4520
  • Loading branch information
yajo committed Feb 27, 2024
1 parent aff2045 commit 8c61202
Show file tree
Hide file tree
Showing 9 changed files with 37 additions and 21 deletions.
7 changes: 6 additions & 1 deletion l10n_fr_siret/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ French company identity numbers SIRET/SIREN/NIC
!! This file is generated by oca-gen-addon-readme !!
!! changes will be overwritten. !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! source digest: sha256:1bef5e4cd64376e2cfc57493b304967a8f2ee67311cee1bf2daaca919a390f29
!! source digest: sha256:ea67eff242155510a0475c4cde9e7cb9b442becd6900f867e9e22be734254c13
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
.. |badge1| image:: https://img.shields.io/badge/maturity-Mature-brightgreen.png
Expand Down Expand Up @@ -43,6 +43,11 @@ The **l10n_fr** module from the official addons adds a *SIRET* field on partners
.. contents::
:local:

Installation
============

It's recommended to install ``python-stdnum>=1.18`` for SIRET support.

Usage
=====

Expand Down
2 changes: 1 addition & 1 deletion l10n_fr_siret/__manifest__.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"website": "https://github.com/OCA/l10n-france",
"license": "AGPL-3",
"depends": ["l10n_fr", "base_view_inheritance_extension"],
"external_dependencies": {"python": ["python-stdnum>=1.18"]},
"external_dependencies": {"python": ["python-stdnum"]},
"data": [
"views/res_partner.xml",
"views/res_company.xml",
Expand Down
1 change: 1 addition & 0 deletions l10n_fr_siret/readme/INSTALL.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
It's recommended to install ``python-stdnum>=1.18`` for SIRET support.
2 changes: 1 addition & 1 deletion l10n_fr_siret/static/description/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ <h1 class="title">French company identity numbers SIRET/SIREN/NIC</h1>
!! This file is generated by oca-gen-addon-readme !!
!! changes will be overwritten. !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! source digest: sha256:1bef5e4cd64376e2cfc57493b304967a8f2ee67311cee1bf2daaca919a390f29
!! source digest: sha256:4fe7ec355c01945f41dfe5012dccac1eaf7047463b803ff24e9cc30b8e42a5e4
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Mature" src="https://img.shields.io/badge/maturity-Mature-brightgreen.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/l10n-france/tree/16.0/l10n_fr_siret"><img alt="OCA/l10n-france" src="https://img.shields.io/badge/github-OCA%2Fl10n--france-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/l10n-france-16-0/l10n-france-16-0-l10n_fr_siret"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/l10n-france&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
<p>The <strong>l10n_fr</strong> module from the official addons adds a <em>SIRET</em> field on partners, but it doesn’t verify its validity. This module <strong>l10n_fr_siret</strong> adds several features:</p>
Expand Down
7 changes: 6 additions & 1 deletion l10n_fr_siret_lookup/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ SIRET Lookup
!! This file is generated by oca-gen-addon-readme !!
!! changes will be overwritten. !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! source digest: sha256:03fba67efc8266229377bb6b509fc696ca15a5c46eef0db0a8d749d51c7d7cdd
!! source digest: sha256:ac452255edc06fcf3217f59520707f90747aa0c82f8f5b4d4bf2fddc31fc1dfb
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
Expand Down Expand Up @@ -51,6 +51,11 @@ In the 2 scenarios, it will update the following fields:
.. contents::
:local:

Installation
============

It's recommended to install ``python-stdnum>=1.18`` for SIRET support.

Usage
=====

Expand Down
2 changes: 1 addition & 1 deletion l10n_fr_siret_lookup/__manifest__.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"depends": [
"l10n_fr_siret",
],
"external_dependencies": {"python": ["requests", "python-stdnum>=1.18"]},
"external_dependencies": {"python": ["requests", "python-stdnum"]},
"data": [
"wizard/fr_siret_lookup_view.xml",
"views/res_partner.xml",
Expand Down
1 change: 1 addition & 0 deletions l10n_fr_siret_lookup/readme/INSTALL.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
It's recommended to install ``python-stdnum>=1.18`` for SIRET support.
35 changes: 20 additions & 15 deletions l10n_fr_siret_lookup/static/description/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ <h1 class="title">SIRET Lookup</h1>
!! This file is generated by oca-gen-addon-readme !!
!! changes will be overwritten. !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! source digest: sha256:03fba67efc8266229377bb6b509fc696ca15a5c46eef0db0a8d749d51c7d7cdd
!! source digest: sha256:ac452255edc06fcf3217f59520707f90747aa0c82f8f5b4d4bf2fddc31fc1dfb
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/l10n-france/tree/16.0/l10n_fr_siret_lookup"><img alt="OCA/l10n-france" src="https://img.shields.io/badge/github-OCA%2Fl10n--france-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/l10n-france-16-0/l10n-france-16-0-l10n_fr_siret_lookup"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/l10n-france&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
<p>This modules updates partner fields via the <cite>SIRENE database &lt;https://data.opendatasoft.com&gt;</cite>. It uses the dataset <em>economicref-france-sirene-v3</em> of <cite>opendatasoft &lt;https://public.opendatasoft.com/explore/dataset/economicref-france-sirene-v3/information/&gt;</cite>. It computes a theorical VAT number from the SIREN and then checks the validity of the VAT number on <a class="reference external" href="https://ec.europa.eu/taxation_customs/vies/">VIES</a> (if invalid, the VAT number is discarded).</p>
Expand All @@ -390,57 +390,62 @@ <h1 class="title">SIRET Lookup</h1>
<p><strong>Table of contents</strong></p>
<div class="contents local topic" id="contents">
<ul class="simple">
<li><a class="reference internal" href="#usage" id="toc-entry-1">Usage</a></li>
<li><a class="reference internal" href="#bug-tracker" id="toc-entry-2">Bug Tracker</a></li>
<li><a class="reference internal" href="#credits" id="toc-entry-3">Credits</a><ul>
<li><a class="reference internal" href="#authors" id="toc-entry-4">Authors</a></li>
<li><a class="reference internal" href="#contributors" id="toc-entry-5">Contributors</a></li>
<li><a class="reference internal" href="#other-credits" id="toc-entry-6">Other credits</a></li>
<li><a class="reference internal" href="#maintainers" id="toc-entry-7">Maintainers</a></li>
<li><a class="reference internal" href="#installation" id="toc-entry-1">Installation</a></li>
<li><a class="reference internal" href="#usage" id="toc-entry-2">Usage</a></li>
<li><a class="reference internal" href="#bug-tracker" id="toc-entry-3">Bug Tracker</a></li>
<li><a class="reference internal" href="#credits" id="toc-entry-4">Credits</a><ul>
<li><a class="reference internal" href="#authors" id="toc-entry-5">Authors</a></li>
<li><a class="reference internal" href="#contributors" id="toc-entry-6">Contributors</a></li>
<li><a class="reference internal" href="#other-credits" id="toc-entry-7">Other credits</a></li>
<li><a class="reference internal" href="#maintainers" id="toc-entry-8">Maintainers</a></li>
</ul>
</li>
</ul>
</div>
<div class="section" id="installation">
<h1><a class="toc-backref" href="#toc-entry-1">Installation</a></h1>
<p>It’s recommended to install <tt class="docutils literal"><span class="pre">python-stdnum&gt;=1.18</span></tt> for SIRET support.</p>
</div>
<div class="section" id="usage">
<h1><a class="toc-backref" href="#toc-entry-1">Usage</a></h1>
<h1><a class="toc-backref" href="#toc-entry-2">Usage</a></h1>
<p>To update an existing parter, go to the partner form view and click on <em>Action &gt; SIREN Lookup</em>.</p>
<p>By default, the search field is filled with Company name. To get more accurate results, you may want to add the City name where the company is registered. Then click on <em>Lookup</em>.</p>
<p>A list of company is displayed. You may want to click on one in order to see corresponding information or directly selecting company from tree view. Once a company is selected, the partner information is updated and a message is logged in the chatter.</p>
</div>
<div class="section" id="bug-tracker">
<h1><a class="toc-backref" href="#toc-entry-2">Bug Tracker</a></h1>
<h1><a class="toc-backref" href="#toc-entry-3">Bug Tracker</a></h1>
<p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/l10n-france/issues">GitHub Issues</a>.
In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us to smash it by providing a detailed and welcomed
<a class="reference external" href="https://github.com/OCA/l10n-france/issues/new?body=module:%20l10n_fr_siret_lookup%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
<p>Do not contact contributors directly about support or help with technical issues.</p>
</div>
<div class="section" id="credits">
<h1><a class="toc-backref" href="#toc-entry-3">Credits</a></h1>
<h1><a class="toc-backref" href="#toc-entry-4">Credits</a></h1>
<div class="section" id="authors">
<h2><a class="toc-backref" href="#toc-entry-4">Authors</a></h2>
<h2><a class="toc-backref" href="#toc-entry-5">Authors</a></h2>
<ul class="simple">
<li>Le Filament</li>
<li>Akretion</li>
</ul>
</div>
<div class="section" id="contributors">
<h2><a class="toc-backref" href="#toc-entry-5">Contributors</a></h2>
<h2><a class="toc-backref" href="#toc-entry-6">Contributors</a></h2>
<ul class="simple">
<li>Benjamin Rivier &lt;benjamin-filament&gt; (<a class="reference external" href="https://le-filament.com">https://le-filament.com</a>)</li>
<li>Remi Cazenave &lt;remi-filament&gt; (<a class="reference external" href="https://le-filament.com">https://le-filament.com</a>)</li>
<li>Alexis de Lattre &lt;<a class="reference external" href="mailto:alexis.delattre&#64;akretion.com">alexis.delattre&#64;akretion.com</a>&gt;</li>
</ul>
</div>
<div class="section" id="other-credits">
<h2><a class="toc-backref" href="#toc-entry-6">Other credits</a></h2>
<h2><a class="toc-backref" href="#toc-entry-7">Other credits</a></h2>
<p>The development of this module has been financially supported by:</p>
<ul class="simple">
<li>Le Filament</li>
</ul>
</div>
<div class="section" id="maintainers">
<h2><a class="toc-backref" href="#toc-entry-7">Maintainers</a></h2>
<h2><a class="toc-backref" href="#toc-entry-8">Maintainers</a></h2>
<p>This module is maintained by the OCA.</p>
<a class="reference external image-reference" href="https://odoo-community.org"><img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" /></a>
<p>OCA, or the Odoo Community Association, is a nonprofit organization whose
Expand Down
1 change: 0 additions & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
pgpy
pypdf>=3.1.0
python-stdnum
python-stdnum>=1.18
requests
requests_oauthlib
unicodecsv
Expand Down

0 comments on commit 8c61202

Please sign in to comment.