Skip to content

Commit

Permalink
[FIX] l10n_fr_siret[_lookup]: remove wrong dependency
Browse files Browse the repository at this point in the history
Odoo 16 depends on both requests and python-stdnum, so there's no need to specify those dependencies.

Besides, [python-stdnum is pinned to 1.16][1]. Thus, when applying OCA/oca-ci#66 locally, the constraint failed. OCA addons should work with the dependencies pinned upstream.

[1]: https://github.com/odoo/odoo/blob/fe4d8e8014e50d4335e0a8b052b5098f3a79bcec/requirements.txt#L48

@moduon MT-4520
  • Loading branch information
yajo committed Jan 31, 2024
1 parent aff2045 commit a9f1d65
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 7 deletions.
2 changes: 1 addition & 1 deletion l10n_fr_siret/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ French company identity numbers SIRET/SIREN/NIC
!! This file is generated by oca-gen-addon-readme !!
!! changes will be overwritten. !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! source digest: sha256:1bef5e4cd64376e2cfc57493b304967a8f2ee67311cee1bf2daaca919a390f29
!! source digest: sha256:4fe7ec355c01945f41dfe5012dccac1eaf7047463b803ff24e9cc30b8e42a5e4
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
.. |badge1| image:: https://img.shields.io/badge/maturity-Mature-brightgreen.png
Expand Down
2 changes: 1 addition & 1 deletion l10n_fr_siret/__manifest__.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"website": "https://github.com/OCA/l10n-france",
"license": "AGPL-3",
"depends": ["l10n_fr", "base_view_inheritance_extension"],
"external_dependencies": {"python": ["python-stdnum>=1.18"]},
"external_dependencies": {"python": ["python-stdnum"]},
"data": [
"views/res_partner.xml",
"views/res_company.xml",
Expand Down
2 changes: 1 addition & 1 deletion l10n_fr_siret/static/description/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ <h1 class="title">French company identity numbers SIRET/SIREN/NIC</h1>
!! This file is generated by oca-gen-addon-readme !!
!! changes will be overwritten. !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! source digest: sha256:1bef5e4cd64376e2cfc57493b304967a8f2ee67311cee1bf2daaca919a390f29
!! source digest: sha256:4fe7ec355c01945f41dfe5012dccac1eaf7047463b803ff24e9cc30b8e42a5e4
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Mature" src="https://img.shields.io/badge/maturity-Mature-brightgreen.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/l10n-france/tree/16.0/l10n_fr_siret"><img alt="OCA/l10n-france" src="https://img.shields.io/badge/github-OCA%2Fl10n--france-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/l10n-france-16-0/l10n-france-16-0-l10n_fr_siret"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/l10n-france&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
<p>The <strong>l10n_fr</strong> module from the official addons adds a <em>SIRET</em> field on partners, but it doesn’t verify its validity. This module <strong>l10n_fr_siret</strong> adds several features:</p>
Expand Down
2 changes: 1 addition & 1 deletion l10n_fr_siret_lookup/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ SIRET Lookup
!! This file is generated by oca-gen-addon-readme !!
!! changes will be overwritten. !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! source digest: sha256:03fba67efc8266229377bb6b509fc696ca15a5c46eef0db0a8d749d51c7d7cdd
!! source digest: sha256:b413fa5d4b0ae43f7eb3f6a8e1d9ce3f722604a9a0e89da9d63f614f3bd7c397
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
Expand Down
2 changes: 1 addition & 1 deletion l10n_fr_siret_lookup/__manifest__.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"depends": [
"l10n_fr_siret",
],
"external_dependencies": {"python": ["requests", "python-stdnum>=1.18"]},
"external_dependencies": {"python": ["requests", "python-stdnum"]},
"data": [
"wizard/fr_siret_lookup_view.xml",
"views/res_partner.xml",
Expand Down
2 changes: 1 addition & 1 deletion l10n_fr_siret_lookup/static/description/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ <h1 class="title">SIRET Lookup</h1>
!! This file is generated by oca-gen-addon-readme !!
!! changes will be overwritten. !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! source digest: sha256:03fba67efc8266229377bb6b509fc696ca15a5c46eef0db0a8d749d51c7d7cdd
!! source digest: sha256:b413fa5d4b0ae43f7eb3f6a8e1d9ce3f722604a9a0e89da9d63f614f3bd7c397
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/l10n-france/tree/16.0/l10n_fr_siret_lookup"><img alt="OCA/l10n-france" src="https://img.shields.io/badge/github-OCA%2Fl10n--france-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/l10n-france-16-0/l10n-france-16-0-l10n_fr_siret_lookup"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/l10n-france&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
<p>This modules updates partner fields via the <cite>SIRENE database &lt;https://data.opendatasoft.com&gt;</cite>. It uses the dataset <em>economicref-france-sirene-v3</em> of <cite>opendatasoft &lt;https://public.opendatasoft.com/explore/dataset/economicref-france-sirene-v3/information/&gt;</cite>. It computes a theorical VAT number from the SIREN and then checks the validity of the VAT number on <a class="reference external" href="https://ec.europa.eu/taxation_customs/vies/">VIES</a> (if invalid, the VAT number is discarded).</p>
Expand Down
1 change: 0 additions & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
pgpy
pypdf>=3.1.0
python-stdnum
python-stdnum>=1.18
requests
requests_oauthlib
unicodecsv
Expand Down

0 comments on commit a9f1d65

Please sign in to comment.