Validate root-level devictree entries in the keymap devicetree #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisandreae
force-pushed
the
validate-devicetree
branch
from
17b31e4
to
a599d03
Compare
In order to prevent unsafe devicetree overriding via keymap files, require the root level devicetree entries in the provided keymap to match a strict allow-list. This is in fact more restrictive than necessary, because it'd be legitimate to define for example a `compatible = "zmk,behavior-hold-tap";` section at the top level, but it's much easier to safely validate.
chrisandreae
force-pushed
the
validate-devicetree
branch
from
a599d03
to
8759c95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to prevent unsafe devicetree overriding in the layout editor via keymap files, require the root level devicetree entries in the provided keymap to match a strict allow-list. This is in fact more restrictive than necessary, because it'd be legitimate to define for example a
compatible = "zmk,behavior-hold-tap";section at the top level, but it's much easier to safely validate.