Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Replicated] release-25.1: clusterversion: set DevBranch=false, version=v25.1.0-beta.1 #149

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

mohini-crl
Copy link
Owner

Replicated from original PR cockroachdb#139158

Original author: blathers-crl[bot]
Original creation date: 2025-01-15T18:17:18Z

Original reviewers: mw5h, jlinder

Original description:

Backport 1/1 commits from cockroachdb#138852 on behalf of @celiala.

/cc @cockroachdb/release


This draft against master is solely to iron out CI failures ahead of next week's branch cut.

This should NOT be merged into master (but rather redirected and merged onto release-25.1 as soon as we do next week's branch cut.

Runbook:

  • set DevelopmentBranch = false (and version.txt to beta.1)
  • run dev generate
  • replace hard-coded mentions of 10000MM.d with MM.d (e.g. 1000024.3, 1000025.1)
    • if files in pkg/sql/catalog/systemschema_test were changed, run:
    • ./dev test pkg/sql/catalog/systemschema_test -f=TestValidateSystemSchemaAfterBootStrap --rewrite
    • run ./dev test pkg/sql/catalog/bootstrap --rewrite -f TestInitialValuesToString and follow instructions from test output -- i.e. update system hash= and tenant hash= in sql/catalog/bootstrap/testdata -- until test passes

Release note: None
Epic: None
Release justification: release-process-only change.


Release justification:

This draft against `master` is solely to iron out CI failures
ahead of next week's branch cut.

This should NOT be merged into `master` (but rather redirected
and merged onto `release-25.1` as soon as we do next week's
branch cut.

Release note: None
Epic: None
Release justification: release-process-only change.
@mohini-crl mohini-crl merged commit 8f691ac into master Jan 17, 2025
1 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants